Re: [PATCH v2 3/3] arm64: dts: qcom: sm8750-mtp: Add eusb2 repeater tuning parameters

[Krishna Kurapati]

On 12/5/2025 7:03 PM, Konrad Dybcio wrote:
> On 12/4/25 5:46 AM, Krishna Kurapati wrote:
> > Add eusb2 repeater tuning parameters for MTP platform.
> >
> > Signed-off-by: Krishna Kurapati <krishna.kurapati@xxxxxxxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> > index c8cb521b4c26..b9a4d1c99816 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> > +++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> > @@ -1041,6 +1041,10 @@ wifi@0 {
> >   &pmih0108_eusb2_repeater {
> >   	status = "okay";
> >   
> > +	qcom,tune-usb2-preem = /bits/ 8 <0x3>;
> > +	qcom,tune-usb2-amplitude = /bits/ 8 <0xa>;
> > +	qcom,squelch-detector-bp = <(-2000)>;
>
> This happens to be the only(?) node in this file that has status first
> instead of last. May I ask you to fix that up, since it's even visible
> in the diff?
>
> Also, does the QRD also need a similar update?

Will fix it up in next revision.

And for QRD, I don't see any updated override params in qrd downstream.

Regards,
Krishna,

> Konrad
>
> > +
> >   	vdd18-supply = <&vreg_l15b_1p8>;
> >   	vdd3-supply = <&vreg_l5b_3p1>;
> >   };