Re: [PATCH] mac80211_hwsim: fix divide error in mac80211_hwsim_link_info_changed

From: Johannes Berg

Date: Sat Dec 06 2025 - 09:56:48 EST


On Sat, 2025-12-06 at 04:33 +0530, Deepakkumar Karn wrote:
> On Fri, 05 Dec 2025 18:39:49 +0100, Johannes Berg wrote:
> > Seems like we should not let userspace do that, to protect all other
> > drivers too, not just hwsim.
>
> As suggested, we should provide a zero-value division check for other
> drivers as well. I will investigate other places where divide errors can
> occur due to edge cases.

What, no no.

> Please let me know if you meant something different. In the meantime,
> I will analyze other drivers for similar cases.

I did. My point is we shouldn't _have_ to check any drivers for this at
all, it's nonsense and higher layers (here cfg80211) should reject it.

johannes