[PATCH] gpib: fluke: Fix an error handling path in fluke_dma_read()
From: Christophe JAILLET
Date: Sat Dec 06 2025 - 02:03:45 EST
It is strange to call dma_unmap_single() with its 'dev' argument
explicitly set to NULL.
It is likely to crash.
Fix it by passing 'board->dev' as done in all other cases in
fluke_dma_read().
Fixes: 55936779f496 ("staging: gpib: Add Fluke cda based cards GPIB driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
---
This patch is compile tested only.
---
drivers/gpib/eastwood/fluke_gpib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpib/eastwood/fluke_gpib.c b/drivers/gpib/eastwood/fluke_gpib.c
index 3ae848e3f738..61eca22dc2b0 100644
--- a/drivers/gpib/eastwood/fluke_gpib.c
+++ b/drivers/gpib/eastwood/fluke_gpib.c
@@ -586,7 +586,7 @@ static int fluke_dma_read(struct gpib_board *board, u8 *buffer,
DMA_PREP_INTERRUPT | DMA_CTRL_ACK);
if (!tx_desc) {
dev_err(board->gpib_dev, "failed to allocate dma transmit descriptor\n");
- dma_unmap_single(NULL, bus_address, length, DMA_FROM_DEVICE);
+ dma_unmap_single(board->dev, bus_address, length, DMA_FROM_DEVICE);
return -EIO;
}
tx_desc->callback = fluke_dma_callback;
--
2.52.0