Re: [PATCH v2 2/7] i2c: qcom-cci: Add msm8953 compatible
From: Luca Weiss
Date: Fri Dec 05 2025 - 23:03:34 EST
Hi,
Ping for someone to pick up this patch please!
Regards
Luca
Luca Weiss <luca@xxxxxxxxxxxx> schreef op 29 oktober 2025 01:40:47 GMT+09:00:
>Add a config for the v1.2.5 CCI found on msm8953 which has different
>values in .params compared to others already supported in the driver.
>
>Reviewed-by: Loic Poulain <loic.poulain@xxxxxxxxxxxxxxxx>
>Acked-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
>Signed-off-by: Luca Weiss <luca@xxxxxxxxxxxx>
>---
> drivers/i2c/busses/i2c-qcom-cci.c | 46 +++++++++++++++++++++++++++++++++++++++
> 1 file changed, 46 insertions(+)
>
>diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c
>index e631d79baf14..884055df1560 100644
>--- a/drivers/i2c/busses/i2c-qcom-cci.c
>+++ b/drivers/i2c/busses/i2c-qcom-cci.c
>@@ -783,8 +783,54 @@ static const struct cci_data cci_v2_data = {
> },
> };
>
>+static const struct cci_data cci_msm8953_data = {
>+ .num_masters = 2,
>+ .queue_size = { 64, 16 },
>+ .quirks = {
>+ .max_write_len = 11,
>+ .max_read_len = 12,
>+ },
>+ .params[I2C_MODE_STANDARD] = {
>+ .thigh = 78,
>+ .tlow = 114,
>+ .tsu_sto = 28,
>+ .tsu_sta = 28,
>+ .thd_dat = 10,
>+ .thd_sta = 77,
>+ .tbuf = 118,
>+ .scl_stretch_en = 0,
>+ .trdhld = 6,
>+ .tsp = 1
>+ },
>+ .params[I2C_MODE_FAST] = {
>+ .thigh = 20,
>+ .tlow = 28,
>+ .tsu_sto = 21,
>+ .tsu_sta = 21,
>+ .thd_dat = 13,
>+ .thd_sta = 18,
>+ .tbuf = 32,
>+ .scl_stretch_en = 0,
>+ .trdhld = 6,
>+ .tsp = 3
>+ },
>+ .params[I2C_MODE_FAST_PLUS] = {
>+ .thigh = 16,
>+ .tlow = 22,
>+ .tsu_sto = 17,
>+ .tsu_sta = 18,
>+ .thd_dat = 16,
>+ .thd_sta = 15,
>+ .tbuf = 19,
>+ .scl_stretch_en = 1,
>+ .trdhld = 3,
>+ .tsp = 3
>+ },
>+};
>+
> static const struct of_device_id cci_dt_match[] = {
> { .compatible = "qcom,msm8226-cci", .data = &cci_v1_data},
>+ { .compatible = "qcom,msm8953-cci", .data = &cci_msm8953_data},
> { .compatible = "qcom,msm8974-cci", .data = &cci_v1_5_data},
> { .compatible = "qcom,msm8996-cci", .data = &cci_v2_data},
>
>