Re: [PATCH v1 3/4] mm/rmap: fix two comments related to huge_pmd_unshare()

From: Rik van Riel

Date: Fri Dec 05 2025 - 21:51:17 EST


On Fri, 2025-12-05 at 22:35 +0100, David Hildenbrand (Red Hat) wrote:
> PMD page table unsharing no longer touches the refcount of a PMD page
> table. Also, it is not about dropping the refcount of a "PMD page"
> but
> the "PMD page table".
>
> Let's just simplify by saying that the PMD page table was unmapped,
> consequently also unmapping the folio that was mapped into this page.
>
> This code should be deduplicated in the future.
>
> Fixes: 59d9094df3d7 ("mm: hugetlb: independent PMD page table shared
> count")
> Cc: Liu Shixin <liushixin2@xxxxxxxxxx>
> Signed-off-by: David Hildenbrand (Red Hat) <david@xxxxxxxxxx>
>
Reviewed-by: Rik van Riel <riel@xxxxxxxxxxx>


--
All Rights Reversed.