Re: [PATCH v5 2/4] misc: fastrpc: Rename phys to dma_addr for clarity

From: Dmitry Baryshkov

Date: Fri Dec 05 2025 - 21:26:06 EST


On Tue, Dec 02, 2025 at 11:36:26AM +0530, Kumari Pallavi wrote:
> Update all references of buf->phys and map->phys to buf->dma_addr and
> map->dma_addr to accurately represent that these fields store DMA
> addresses, not physical addresses. This change improves code clarity
> and aligns with kernel conventions for dma_addr_t usage.

Please _start_ by describing the problem or the issue the patch is
trying to solve.

>
> Signed-off-by: Kumari Pallavi <kumari.pallavi@xxxxxxxxxxxxxxxx>
> ---
> drivers/misc/fastrpc.c | 77 ++++++++++++++++++++++--------------------
> 1 file changed, 41 insertions(+), 36 deletions(-)
>

--
With best wishes
Dmitry