Re: [PATCH] iommufd: fix building without dmabuf
From: Jason Gunthorpe
Date: Fri Dec 05 2025 - 14:50:13 EST
On Thu, Dec 04, 2025 at 11:03:29AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> When DMABUF is disabled, trying to use it causes a link failure:
>
> x86_64-linux-ld: drivers/iommu/iommufd/io_pagetable.o: in function `iopt_map_file_pages':
> io_pagetable.c:(.text+0x1735): undefined reference to `dma_buf_get'
> x86_64-linux-ld: io_pagetable.c:(.text+0x1775): undefined reference to `dma_buf_put'
>
> Fixes: 44ebaa1744fd ("iommufd: Accept a DMABUF through IOMMU_IOAS_MAP_FILE")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/iommu/iommufd/io_pagetable.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
I picked this up anyhow since it looked like adding #ifdef stubs to
dma_buf.h was going to be a bigger thing
> + if (IS_ENABLED(CONFIG_DMABUF_HEAPS))
> + dmabuf = dma_buf_get(fd);
But this needs to be:
if (IS_ENABLED(CONFIG_DMA_SHARED_BUFFER))
dmabuf = dma_buf_get(fd);
I fixed it
Thanks,
Jason