Re: [PATCH net v3] broadcom: b44: prevent uninitialized value usage

[Michael Chan]

On Fri, Dec 5, 2025 at 7:59 AM Alexey Simakov <bigalex934@xxxxxxxxx> wrote:
>
> On execution path with raised B44_FLAG_EXTERNAL_PHY, b44_readphy()
> leaves bmcr value uninitialized and it is used later in the code.
>
> Add check of this flag at the beginning of the b44_nway_reset() and
> exit early of the function with restarting autonegotiation if an
> external PHY is used.
>
> Found by Linux Verification Center (linuxtesting.org) with Svace.
>
> Fixes: 753f492093da ("[B44]: port to native ssb support")
> Reviewed-by: Jonas Gorski <jonas.gorski@xxxxxxxxx>
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
> Signed-off-by: Alexey Simakov <bigalex934@xxxxxxxxx>

Reviewed-by: Michael Chan <michael.chan@xxxxxxxxxxxx>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature