Re: [PATCH] gpio: tb10x: fix OF_GPIO dependency

[Bartosz Golaszewski]

On Thu, Dec 4, 2025 at 10:50 AM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> Selecting OF_GPIO is generally not allowed, it always gets enabled
> when both GPIOLIB and OF are turned on.
>
> The tb10x driver now warns about this after it was enabled for
> compile-testing:
>
> WARNING: unmet direct dependencies detected for OF_GPIO
>   Depends on [n]: GPIOLIB [=y] && OF [=n] && HAS_IOMEM [=y]
>   Selected by [y]:
>   - GPIO_TB10X [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] && (ARC_PLAT_TB10X || COMPILE_TEST [=y])
>
> Use the usual 'depends on' here.
>
> Fixes: 682fbb18e14c ("gpio: tb10x: allow building the module with COMPILE_TEST=y")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---

Hi Arnd!

Actually a better fix is to simply drop this select and not introduce
the depends on. This driver doesn't call any symbols from gpiolib-of.h
and even then - they provide stubs. This also limits the COMPILE_TEST
coverage to systems with OF_GPIO selected.

Same for the other patch you sent.

Bart