Re: [PATCH v7 2/2] regulator: max77675: Add MAX77675 regulator driver

[Krzysztof Kozlowski]

On 05/12/2025 05:56, Joan-Na-adi wrote:
> +
> +	if (int_glbl & MAX77675_INT_EN_R_BIT)
> +		dev_dbg(maxreg->dev, "nEN Rising Edge Interrupt occurred\n");
> +
> +	if (int_glbl & MAX77675_INT_EN_F_BIT)
> +		dev_dbg(maxreg->dev, "nEN Falling Edge Interrupt occurred\n");
> +
> +	return 0;
> +}
> +
> +static int max77675_regulator_probe(struct i2c_client *client)
> +{
> +	struct max77675_regulator *maxreg;
> +	struct regulator_config config = {};
> +	struct device_node *regulators_np __free(device_node) = NULL;

This is an undesired syntax explicitly documented as one to avoid. You
need here proper assignment, not NULL. Please don't use cleanup.h if you
do not intend to follow it because it does not make the code simpler.


Best regards,
Krzysztof