Re: [PATCH v4] staging: greybus: arche-apb-ctrl: switch to device_property_read_bool

From: Dan Carpenter

Date: Fri Dec 05 2025 - 02:27:14 EST


On Thu, Dec 04, 2025 at 08:17:53PM -0300, Julioccps wrote:
> Switch from the deprecated of_property_read_bool() to the common
> device_property_read_bool() API. This makes the driver agnostic to
> the underlying firmware interface (DT or ACPI) and simplifies the
> logic.
>
> Since the driver is no longer strictly dependent on Device Tree,
> include <linux/mod_devicetable.h> directly for the struct
> of_device_id definition, instead of relying on implicit inclusion
> via <linux/of_irq.h>, which has been removed as it is unused.
>
> Also rename apb_ctrl_get_devtree_data() to apb_ctrl_get_fw_data()
> to better reflect the agnostic nature of the new implementation.
>
> Signed-off-by: Julio Cesar Carvalho de Paula Souza <julio191096@xxxxxxxxx>
> ---

Same comments as v3.

regards,
dan carpenter