Re: [PATCH] hwmon: (emc2305): fix device node refcount leak in error path
From: Guenter Roeck
Date: Thu Dec 04 2025 - 23:07:40 EST
On Fri, Dec 05, 2025 at 11:15:13AM +0800, xiaopeitux@xxxxxxxxxxx wrote:
> From: Pei Xiao <xiaopei01@xxxxxxxxxx>
>
> The for_each_child_of_node() macro automatically manages device node
> reference counts during normal iteration. However, when breaking out
> of the loop early with return, the current iteration's node is not
> automatically released, leading to a reference count leak.
>
> Fix this by adding of_node_put(child) before returning from the loop
> when emc2305_set_single_tz() fails.
>
> This issue could lead to memory leaks over multiple probe cycles.
>
> Signed-off-by: Pei Xiao <xiaopei01@xxxxxxxxxx>
Applied.
Thanks,
Guenter