Re: [PATCH v1 1/4] bpf: Add wakeup_source iterator
From: kernel test robot
Date: Thu Dec 04 2025 - 22:17:58 EST
Hi Samuel,
kernel test robot noticed the following build errors:
[auto build test ERROR on bpf-next/master]
[also build test ERROR on bpf/master shuah-kselftest/next shuah-kselftest/fixes linus/master v6.18 next-20251204]
[cannot apply to bpf-next/net]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Samuel-Wu/bpf-Add-wakeup_source-iterator/20251204-111108
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link: https://lore.kernel.org/r/20251204025003.3162056-2-wusamuel%40google.com
patch subject: [PATCH v1 1/4] bpf: Add wakeup_source iterator
config: um-randconfig-r052-20251205 (https://download.01.org/0day-ci/archive/20251205/202512051019.IljjrKRb-lkp@xxxxxxxxx/config)
compiler: gcc-13 (Debian 13.3.0-16) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251205/202512051019.IljjrKRb-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512051019.IljjrKRb-lkp@xxxxxxxxx/
All error/warnings (new ones prefixed by >>):
kernel/bpf/wakeup_source_iter.c: In function 'wakeup_source_iter_seq_start':
>> kernel/bpf/wakeup_source_iter.c:20:20: error: implicit declaration of function 'wakeup_sources_read_lock'; did you mean 'wakeup_source_register'? [-Werror=implicit-function-declaration]
20 | *srcuidx = wakeup_sources_read_lock();
| ^~~~~~~~~~~~~~~~~~~~~~~~
| wakeup_source_register
>> kernel/bpf/wakeup_source_iter.c:22:14: error: implicit declaration of function 'wakeup_sources_walk_start'; did you mean 'wakeup_source_register'? [-Werror=implicit-function-declaration]
22 | ws = wakeup_sources_walk_start();
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| wakeup_source_register
>> kernel/bpf/wakeup_source_iter.c:22:12: warning: assignment to 'struct wakeup_source *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
22 | ws = wakeup_sources_walk_start();
| ^
>> kernel/bpf/wakeup_source_iter.c:24:22: error: implicit declaration of function 'wakeup_sources_walk_next' [-Werror=implicit-function-declaration]
24 | ws = wakeup_sources_walk_next(ws);
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/bpf/wakeup_source_iter.c:24:20: warning: assignment to 'struct wakeup_source *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
24 | ws = wakeup_sources_walk_next(ws);
| ^
kernel/bpf/wakeup_source_iter.c: In function 'wakeup_source_iter_seq_next':
>> kernel/bpf/wakeup_source_iter.c:35:16: warning: returning 'int' from a function with return type 'void *' makes pointer from integer without a cast [-Wint-conversion]
35 | return wakeup_sources_walk_next(ws);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/bpf/wakeup_source_iter.c: In function 'wakeup_source_iter_seq_stop':
>> kernel/bpf/wakeup_source_iter.c:43:17: error: implicit declaration of function 'wakeup_sources_read_unlock' [-Werror=implicit-function-declaration]
43 | wakeup_sources_read_unlock(*srcuidx);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +20 kernel/bpf/wakeup_source_iter.c
13
14 static void *wakeup_source_iter_seq_start(struct seq_file *seq, loff_t *pos)
15 {
16 int *srcuidx = seq->private;
17 struct wakeup_source *ws;
18 loff_t i;
19
> 20 *srcuidx = wakeup_sources_read_lock();
21
> 22 ws = wakeup_sources_walk_start();
23 for (i = 0; ws && i < *pos; i++)
> 24 ws = wakeup_sources_walk_next(ws);
25
26 return ws;
27 }
28
29 static void *wakeup_source_iter_seq_next(struct seq_file *seq, void *v, loff_t *pos)
30 {
31 struct wakeup_source *ws = v;
32
33 ++*pos;
34
> 35 return wakeup_sources_walk_next(ws);
36 }
37
38 static void wakeup_source_iter_seq_stop(struct seq_file *seq, void *v)
39 {
40 int *srcuidx = seq->private;
41
42 if (*srcuidx >= 0)
> 43 wakeup_sources_read_unlock(*srcuidx);
44 *srcuidx = -1;
45 }
46
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki