Re: [PATCH 09/10] smb: create common/common.h and common/common.c

From: Namjae Jeon

Date: Thu Dec 04 2025 - 19:35:52 EST


On Thu, Dec 4, 2025 at 2:00 PM <chenxiaosong.chenxiaosong@xxxxxxxxx> wrote:
>
> From: ChenXiaoSong <chenxiaosong@xxxxxxxxxx>
>
> Preparation for moving client/smb2maperror.c to common/.
>
> We can put cifs_md4 and smb2maperror into a single smb_common.ko,
> instead of creating two separate .ko (cifs_md4.ko and smb2maperror.ko).
Sorry, I prefer not to create new *.ko for only smb2maperror.
>
> - rename md4.h -> common.h, and update include guard
> - create common.c, and move module info from cifs_md4.c into common.c
ksmbd does not use md4 in smb/common, I don't prefer this either.
I would appreciate it if you could send me the patch set again except these.
>
> Signed-off-by: ChenXiaoSong <chenxiaosong@xxxxxxxxxx>