Re: [PATCH] drm/panel: novatek-nt35560: avoid on-stack device structure

[Doug Anderson]

Hi,

On Thu, Dec 4, 2025 at 1:45 AM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> A cleanup patch apparently by accident used a local device structure
> instead of a pointer to one in the nt35560_read_id() function, causing
> a warning about stack usage:
>
> drivers/gpu/drm/panel/panel-novatek-nt35560.c: In function 'nt35560_read_id':
> drivers/gpu/drm/panel/panel-novatek-nt35560.c:249:1: error: the frame size of 1296 bytes is larger than 1280 bytes [-Werror=frame-larger-than=]
>
> Change this to a pointer as was liley intended here.
>
> Fixes: 5fbc0dbb92d6 ("drm/panel: novatek-nt35560: Clean up driver")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
>  drivers/gpu/drm/panel/panel-novatek-nt35560.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Whoops! Not sure how I missed that in code review. Thanks for the fix!

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

Pushed to drm-misc-fixes:

[1/1] drm/panel: novatek-nt35560: avoid on-stack device structure
      commit: 1a7a7b80a22448dff55e1ad69a4681fd8b760b85