Re: [PATCH -next] cgroup: Use descriptor table to unify mount flag management

[Michal Koutný]

On Tue, Dec 02, 2025 at 09:53:11PM +0800, Chen Ridong <chenridong@xxxxxxxxxxxxxxx> wrote:
> What do you think about this approach? If you have any suggestions for further improvement, I'd be
> happy to incorporate them.

Yes, it's better due to the single place of definition.
It made me to look around at some other filesystems from a random sample
(skewed towards ones with more options) and I see:
- many of them simply use the big switch/case in .parse_param,
- ext4 has its specialized ext4_mount_opts array whose order needn't
  match ext4_param_specs thanks to dynamic search.

All in all, I appreciate your effort, however, I'm not sure it's worth
to deviate from the custom of other FS implementations.

Michal

Attachment: signature.asc
Description: PGP signature