Re: [PATCH v4 3/8] dt-bindings: display/msm: gpu: Document A612 GPU

[Krzysztof Kozlowski]

On 04/12/2025 14:21, Akhil P Oommen wrote:
>  
>    clocks:
> -    minItems: 2
> +    minItems: 1
>      maxItems: 7
>  
>    clock-names:
> -    minItems: 2
> +    minItems: 1
>      maxItems: 7
>  
>    reg:
> @@ -388,6 +388,32 @@ allOf:
>          - clocks
>          - clock-names
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: qcom,adreno-612.0
> +    then:
> +      properties:
> +        clocks:
> +          items:
> +            - description: GPU Core clock
> +
> +        clock-names:
> +          items:
> +            - const: core
> +
> +        reg-names:
> +          minItems: 1
> +          items:
> +            - const: kgsl_3d0_reg_memory
> +            - const: cx_mem
> +            - const: cx_dbgc

The patch overall gets better, thanks, but I think I asked about this
already - why you don't have the list strict? I don't see reason for
making list flexible and I don't see the explanation in the commit msg.
Either this should be fixed-size (so minItems: 3 and same for reg:) or
you should document reasons WHY in the commit msg. Otherwise next time I
will ask the same. :(


Best regards,
Krzysztof