Re: [PATCH] mm/damon/tests/core-kunit: avoid damos_test_commit stack warning

From: SeongJae Park

Date: Thu Dec 04 2025 - 10:01:56 EST


On Thu, 4 Dec 2025 11:03:54 +0100 Arnd Bergmann <arnd@xxxxxxxxxx> wrote:

> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The newly added damos_test_commit() constructs multiple large structures
> on the stack, which exceeds the warning limit in some cases:
>
> In file included from mm/damon/core.c:2941:
> mm/damon/tests/core-kunit.h: In function 'damos_test_commit':
> mm/damon/tests/core-kunit.h:965:1: error: the frame size of 1520 bytes is larger than 1280 bytes [-Werror=frame-larger-than=]
>
> Split this function up into two separate ones that are called sequentially,
> so they can occupy the same stack slots.

Thank you for catching and fixing this, Arnd!

>
> Fixes: 299a88f6ec13 ("mm/damon/tests/core-kunit: add damos_commit() test")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Reviewed-by: SeongJae Park <sj@xxxxxxxxxx>


Thanks,
SJ

[...]