Re: [PATCH RFC 0/6] iio: core: Introduce cleanup.h support for mode locks

From: Nuno Sá

Date: Thu Dec 04 2025 - 09:35:52 EST


On Wed, 2025-12-03 at 14:18 -0500, Kurt Borja wrote:
> Hi,
>
> In a recent driver review discussion [1], Andy Shevchenko suggested we
> add cleanup.h support for the lock API:
>
> iio_device_claim_{direct,buffer_mode}().

We already went this patch and then reverted it. I guess before we did not had
ACQUIRE() and ACQUIRE_ERR() but I'm not sure that makes it much better. Looking at the
last two patches on how we are handling the buffer mode stuff, I'm really not convinced...

Also, I have doubts sparse can keep up with the __cleanup stuff so I'm not sure the
annotations much make sense if we go down this path. Unless we want to use both 
approaches which is also questionable.

- Nuno Sá