Re: [PATCH net] broadcom: b44: prevent uninitialized value usage

[Andrew Lunn]

> > +++ b/drivers/net/ethernet/broadcom/b44.c
> > @@ -1789,6 +1789,9 @@ static int b44_nway_reset(struct net_device *dev)
> >  	u32 bmcr;
> >  	int r;
> >  
> > +	if (bp->flags & B44_FLAG_EXTERNAL_PHY)
> > +		return 0;
> 
> Wouldn't the right fix here to call phy_ethtool_nway_reset(dev->phydev); instead
> of just returning 0? That way it properly restarts auto-negotiation even in this
> case.

Actually, yes. ksettings_set() etc do exactly that. Let me change my
Reviewed by into a Change Request.

Thanks
    Andrew

---
pw-bot: cr