Re: [PATCH v5 01/12] arm64: dts: qcom: sdm845-lg-common: Sort nodes and properties

[Konrad Dybcio]

On 12/4/25 2:11 PM, Krzysztof Kozlowski wrote:
> On 03/12/2025 10:40, Paul Sajna wrote:
>> Improve adherance to style guidelines below:
>> https://docs.kernel.org/devicetree/bindings/dts-coding-style.html
>>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
>> Signed-off-by: Paul Sajna <sajattack@xxxxxxxxxxxxxxxx>
>> ---
>>  arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 144 ++++++++++++++-----------
>>  1 file changed, 82 insertions(+), 62 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
>> index 0ee2f4b99fbd..b8ab64a8de1c 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
>> @@ -38,11 +38,6 @@ reserved-memory {
>>  		#size-cells = <2>;
>>  		ranges;
>>  
>> -		qseecom_mem: memory@b2000000 {
>> -			reg = <0 0xb2000000 0 0x1800000>;
>> -			no-map;
>> -		};
>> -
>>  		gpu_mem: memory@8c415000 {
>>  			reg = <0 0x8c415000 0 0x2000>;
>>  			no-map;
>> @@ -99,7 +94,12 @@ memory@9d400000 {
>>  			no-map;
>>  		};
>>  
>> -		rmtfs_mem: rmtfs-region@f0800000 {
> 
> Why?
> 
>> +		qseecom_mem: memory@b2000000 {
>> +			reg = <0 0xb2000000 0 0x1800000>;
>> +			no-map;
>> +		};
>> +
>> +		rmtfs_mem: memory@f0801000 {
> 
> No, you are doing much more then sorting. You are changing names to
> incorrect ones and maybe (tricky to say) change also unit address to
> buggy one.
> 
> @Konrad,
> Why are we started resorting the addresses BEFORE we came up with proper
> linter? Why the rule suddenly changed?

I don't really mind small cleanups that are done as part of bigger
feature additions, as opposed to fixing a single file for the sake
of it

Konrad