Re: [PATCH] usb: typec: ucsi: huawei-gaokin: add DRM dependency

[Heikki Krogerus]

Thu, Dec 04, 2025 at 11:11:07AM +0100, Arnd Bergmann kirjoitti:
> From: Arnd Bergmann <arnd@xxxxxxxx>
> 
> Selecting DRM_AUX_HPD_BRIDGE is not possible from a built-in driver when
> CONFIG_DRM=m:
> 
> WARNING: unmet direct dependencies detected for DRM_AUX_HPD_BRIDGE
>   Depends on [m]: HAS_IOMEM [=y] && DRM [=m] && DRM_BRIDGE [=y] && OF [=y]
>   Selected by [y]:
>   - UCSI_HUAWEI_GAOKUN [=y] && USB_SUPPORT [=y] && TYPEC [=y] && TYPEC_UCSI [=y] && EC_HUAWEI_GAOKUN [=y] && DRM_BRIDGE [=y] && OF [=y]
> 
> Add the same dependency we have in similar drivers to work around this.
> 
> Fixes: 00327d7f2c8c ("usb: typec: ucsi: add Huawei Matebook E Go ucsi driver")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

> ---
>  drivers/usb/typec/ucsi/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/typec/ucsi/Kconfig b/drivers/usb/typec/ucsi/Kconfig
> index 7fcb1e1de5d6..b812be4d0e67 100644
> --- a/drivers/usb/typec/ucsi/Kconfig
> +++ b/drivers/usb/typec/ucsi/Kconfig
> @@ -96,6 +96,7 @@ config UCSI_LENOVO_YOGA_C630
>  config UCSI_HUAWEI_GAOKUN
>  	tristate "UCSI Interface Driver for Huawei Matebook E Go"
>  	depends on EC_HUAWEI_GAOKUN
> +	depends on DRM || !DRM
>  	select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF
>  	help
>  	  This driver enables UCSI support on the Huawei Matebook E Go tablet,
> -- 
> 2.39.5

-- 
heikki