Re: [PATCH v2 2/2] iio: adc: ad9467: add support for ad9211

[Andy Shevchenko]

On Thu, Dec 04, 2025 at 08:01:04AM +0000, Tomas Melin wrote:
> The AD9211 is a 10-bit monolithic sampling analog-to-digital
> converter optimized for high performance, low power, and ease
> of use. The product operates at up to a 300 MSPS conversion
> rate and is optimized for outstanding dynamic performance
> in wideband carrier and broadband systems.
> 
> The scale table implemented here is not an exact match with the
> datasheet as the table presented there is missing some information.
> The reference presents these values as being linear,
> but that does not add up. There is information missing in the table.
> Implemented scale table matches values at the middle and at the ends,
> smoothing the curve towards middle and end.
> Impact on end result from deviation in scale factor affects only software
> using it for scaling. All the possible hw-settings are also available with
> this implementation.


Some amendment in the headers would be nice to have,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

...

+ array_size.h

>  #include <linux/delay.h>
>  #include <linux/gpio/consumer.h>
>  #include <linux/of.h>
> +#include <linux/units.h>
>  

You can drop one blank line here.

-- 
With Best Regards,
Andy Shevchenko