Re: [PATCH 4/6 v8] sched/fair: Add push task mechanism for fair

From: Peter Zijlstra

Date: Thu Dec 04 2025 - 05:46:15 EST


On Tue, Dec 02, 2025 at 07:12:40PM +0100, Vincent Guittot wrote:


> +static void fair_add_pushable_task(struct rq *rq, struct task_struct *p)
> +{
> + if (sched_push_task_enabled() && fair_push_task(rq, p)) {
> + plist_del(&p->pushable_tasks, &rq->cfs.pushable_tasks);
> + plist_node_init(&p->pushable_tasks, p->prio);
> + plist_add(&p->pushable_tasks, &rq->cfs.pushable_tasks);
> + }
> +}

I might have asked before, but if there was an answer, I have forgotten
:/

Why is this a prio-list? It seems to me that we don't particularly care
about keeping this push sorted by nice value, right?