Re: [PATCH 1/4] media: qcom: iris: Add intra refresh support for gen1 encoder

[Wangao Wang]

On 2025/12/3 12:28, Dikshita Agarwal wrote:
> > +
> > +#define HFI_INTRA_REFRESH_NONE			0x1
> > +#define HFI_INTRA_REFRESH_CYCLIC		0x2
> > +#define HFI_INTRA_REFRESH_ADAPTIVE		0x3
> > +#define HFI_INTRA_REFRESH_CYCLIC_ADAPTIVE	0x4
>
> HFI_INTRA_REFRESH_ADAPTIVE and HFI_INTRA_REFRESH_CYCLIC_ADAPTIVE are not
> being used, do we need these macros here?

I referred to the Venus driver, which also defines it but does not use it.

> > +	{
> > +		.cap_id = IR_PERIOD,
> > +		.min = 0,
> > +		.max = INT_MAX,
>
> is this value correct? please recheck.

This value is incorrect; I will fix it in v2.

--
Best Regards,
Wangao