Re: [RFC v2 2/2] scsi: scsi_debug: enable sdebug_sector_size > PAGE_SIZE
From: Bart Van Assche
Date: Wed Dec 03 2025 - 21:03:07 EST
On 12/3/25 1:05 PM, sw.prabhu6@xxxxxxxxx wrote:
diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
index b2ab97be5db3..b5839e62d3bb 100644
--- a/drivers/scsi/scsi_debug.c
+++ b/drivers/scsi/scsi_debug.c
@@ -8459,13 +8459,8 @@ static int __init scsi_debug_init(void)
} else if (sdebug_ndelay > 0)
sdebug_jdelay = JDELAY_OVERRIDDEN;
- switch (sdebug_sector_size) {
- case 512:
- case 1024:
- case 2048:
- case 4096:
- break;
- default:
+ if (sdebug_sector_size < 512 || sdebug_sector_size > BLK_MAX_BLOCK_SIZE ||
+ !is_power_of_2(sdebug_sector_size)) {
pr_err("invalid sector_size %d\n", sdebug_sector_size);
return -EINVAL;
}
Please use blk_validate_block_size() instead of open-coding it.
Thanks,
Bart.