Re: [PATCH RESEND] media: camss: csiphy: Make CSIPHY status macro cross-platform

[Bryan O'Donoghue]

On 03/12/2025 16:57, Andi Shyti wrote:
> Hi,
>
> On Mon, Dec 01, 2025 at 06:18:51PM +0100, Konrad Dybcio wrote:
> > On 12/1/25 3:48 PM, Vijay Kumar Tumati wrote:
> > > On 12/1/2025 4:20 AM, Konrad Dybcio wrote:
> > > > On 12/1/25 7:25 AM, Hangxiang Ma wrote:
> > > > > The current value of '0xb0' that represents the offset to the status
> > > > > registers within the common registers of the CSIPHY has been changed on
> > > > > the newer SOCs and it requires generalizing the macro using a new
> > > > > variable 'common_status_offset'. This variable is initialized in the
> > > > > csiphy_init() function.
> > > > "offset" + "common_status_offset" is confusing
> > > >
> > > > Let's maybe add some platform data where we store the actual offset of
> > > > the registers in question and pass a csiphy ptr as an argument
> > > >
> > > > Konrad
> > > Hi Konrad, may be I didn't follow correctly. This is consistent with the way we maintain the other SOC specific reg offsets / data in the CSIPHY driver, in csiphy_device_regs, isn't it? I seem to think it's clearer this way for the reader to see all the offsets at one place. No? Thanks.
> >
> > I thought this driver was a little more complex.. anyway, big
> > changes that will make this prettier are coming so this works too in
> > the meantime
>
> After this short discussion, in order to get it in, can someone
> from Qualcomm ack/r-b it?
>
> Thanks,
> Andi

I'll pick it up per nomal.

---
bod