Re: [PATCH v2 01/22] media: dt-bindings: media: rockchip-rga: add rockchip,rk3588-rga3

[Sven Püschel]

Hi Krzysztof,

On 12/3/25 9:28 PM, Krzysztof Kozlowski wrote:
> On 03/12/2025 16:52, Sven Püschel wrote:
> > Add a new compatible for the RGA3 (Raster Graphic Acceleration 3)
> > peripheral found on the RK3588 SoC.
> >
> > The existing rga node refers to the RGA2 peripheral. The RK3588
> What is "existing rga node"? There is no node here. This is a patch for
> bindings, so you say which hardware existing binding describes and what
> are the differences against that older hardware.
Yeah that is misleading. I refer to the existing binding/compatible 
values of rockchip-rk3xxx-rga which describe the hardware named RGA2 in 
the rk3588 TRM.
> > contains one RGA2 core and two RGA3 cores. Both feature a similar
> > functionality of scaling, cropping and rotating of up to two input
> > images into one output image. Key differences of the RGA3 are:
> >
> > - supports 10bit YUV output formats
> > - supports 8x8 tiles and FBCD as inputs and outputs
> > - supports BT2020 color space conversion
> > - max output resolution of (8192-64)x(8192-64)
> > - MMU can map up to 32G DDR RAM
> > - fully planar formats (3 planes) are not supported
> > - max scale up/down factor of 8
> "differences" in meaning nothing above is supported by RGA2?

except the last two points yes. The RGA2 supports fully planar formats 
with 3 planes and can scale up to a factor of 16. For the scaling I can 
add a note to make it more obvious that the RGA3 is worse in this regard.

Sincerely
    Sven

> > Signed-off-by: Sven Püschel <s.pueschel@xxxxxxxxxxxxxx>
> > ---
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
>
>
> Best regards,
> Krzysztof