Re: [PATCH 18/31] gpu: nova-core: Hopper/Blackwell: add needs_large_reserved_mem()

[Timur Tabi]

On Tue, 2025-12-02 at 21:59 -0800, John Hubbard wrote:
> +
> +    #[expect(dead_code)]
> +    pub(crate) fn needs_large_reserved_mem(&self) -> bool {
> +        matches!(self.arch(), Architecture::Hopper | Architecture::Blackwell)
> +    }

Wouldn't it be cleaner to return the actual amount of memory needed, instead of just saying, "Hey, I
need more, whatever more is"?

         let frts_offset = if !resume {
             let mut frts_reserved_size = if chipset.needs_large_reserved_mem() {
-                0x220000 // heap_size_non_wpr for Hopper/Blackwell+
+                crate::fb::calc_non_wpr_heap_size(chipset)
             } else {
                 total_reserved_size
             };

Maybe have calc_non_wpr_heap_size() be a HAL function?