Re: [PATCH net-next] gve: Move gve_init_clock to after AQ CONFIGURE_DEVICE_RESOURCES call

[Simon Horman]

On Tue, Dec 02, 2025 at 08:02:07PM +0000, Harshitha Ramamurthy wrote:
> From: Tim Hostetler <thostet@xxxxxxxxxx>
> 
> commit 46e7860ef941 ("gve: Move ptp_schedule_worker to gve_init_clock")
> moved the first invocation of the AQ command REPORT_NIC_TIMESTAMP to
> gve_probe(). However, gve_init_clock() invoking REPORT_NIC_TIMESTAMP is
> not valid until after gve_probe() invokes the AQ command
> CONFIGURE_DEVICE_RESOURCES.
> 
> Failure to do so results in the following error:
> 
> gve 0000:00:07.0: failed to read NIC clock -11
> 
> This was missed earlier because the driver under test was loaded at
> runtime instead of boot-time. The boot-time driver had already
> initialized the device, causing the runtime driver to successfully call
> gve_init_clock() incorrectly.
> 
> Fixes: 46e7860ef941 ("gve: Move ptp_schedule_worker to gve_init_clock")
> Reviewed-by: Ankit Garg <nktgrg@xxxxxxxxxx>
> Signed-off-by: Tim Hostetler <thostet@xxxxxxxxxx>
> Signed-off-by: Harshitha Ramamurthy <hramamurthy@xxxxxxxxxx>

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>