Re: [PATCH] wifi: cfg80211: sme: store capped length in __cfg80211_connect_result()

[Rolf Reintjes]

Hello Dan,

Am 03.12.2025 um 12:14 schrieb Dan Carpenter:
> The QGenie AI code review tool

Could you tell us more about this tool? Is there a web page of this 
tool, how do you use this tool?

I found https://qgenie.ai/ but this is not a code review tool.

Rolf

> says we should store the capped length to
> wdev->u.client.ssid_len.  The AI is correct.
>
> Fixes: 62b635dcd69c ("wifi: cfg80211: sme: cap SSID length in __cfg80211_connect_result()")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
>   net/wireless/sme.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/wireless/sme.c b/net/wireless/sme.c
> index 3a028ff287fb..4e629ca305bc 100644
> --- a/net/wireless/sme.c
> +++ b/net/wireless/sme.c
> @@ -910,7 +910,7 @@ void __cfg80211_connect_result(struct net_device *dev,
>   
>   			ssid_len = min(ssid->datalen, IEEE80211_MAX_SSID_LEN);
>   			memcpy(wdev->u.client.ssid, ssid->data, ssid_len);
> -			wdev->u.client.ssid_len = ssid->datalen;
> +			wdev->u.client.ssid_len = ssid_len;
>   			break;
>   		}
>   		rcu_read_unlock();