Re: [PATCH v2 2/4] moduleparam: include required headers explicitly

From: Andy Shevchenko

Date: Wed Dec 03 2025 - 12:01:09 EST


On Wed, Dec 03, 2025 at 11:23:23AM -0500, Yury Norov (NVIDIA) wrote:
> The following patch drops moduleparam.h dependency on kernel.h. In
> preparation to it, list all the required headers explicitly.

> Suggested-by: Petr Pavlu <petr.pavlu@xxxxxxxx>

> CC: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

You can move this line after --- or use --cc when formatting patch,
no need to pollute the commit message with it.

In any case, the change LGTM and you can just replace the above with

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

--
With Best Regards,
Andy Shevchenko