Re: [PATCH] objtool: Fix stack overflow in validate_branch()

[Ingo Molnar]

* Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:

> Here's with reading /proc/self/maps and rlimit, it's not too bad:
> 
> From: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> Subject: [PATCH] objtool: Add signal error handling
> 
> When the kernel build fails due to an objtool seg fault, the error
> message is confusing:
> 
>   make[5]: *** [scripts/Makefile.build:503: drivers/scsi/qla2xxx/qla2xxx.o] Error 139
>   make[5]: *** Deleting file 'drivers/scsi/qla2xxx/qla2xxx.o'
>   make[4]: *** [scripts/Makefile.build:556: drivers/scsi/qla2xxx] Error 2
>   make[3]: *** [scripts/Makefile.build:556: drivers/scsi] Error 2
>   make[2]: *** [scripts/Makefile.build:556: drivers] Error 2
>   make[1]: *** [/home/jpoimboe/git/linux/Makefile:2013: .] Error 2
>   make: *** [Makefile:248: __sub-make] Error 2
> 
> Add a signal handler which prints an error message like:
> 
>   drivers/scsi/qla2xxx/qla2xxx.o: error: SIGSEGV: objtool stack overflow!
> 
> or
> 
>   drivers/scsi/qla2xxx/qla2xxx.o: error: SIGSEGV: objtool crash!
> 
> Also, re-raise the signal so the core dump still gets triggered.

Great - this version looks good to me, and I've applied it to
tip:objtool/urgent.

Thanks,

	Ingo