Re: [PATCH V3 5/4] 9p: fix cache option printing in v9fs_show_options

[Dominique Martinet]

Eric Sandeen wrote on Tue, Dec 02, 2025 at 07:09:42PM -0600:
> >> -		seq_printf(m, ",cache=%x", v9ses->cache);
> >> +		seq_printf(m, ",cache=0x%x", v9ses->cache);
> > 
> > What's wrong with "cache=%#x"?
> 
> Nothing, presumably - I did not know this existed TBH.
> 
> (looks like that usage is about 1/10 of 0x%x currently)

I don't have any preference here, but I've folded in %#x when applying
because why not -- I've been seeing it slightly more often lately so I
guess it's the "modern way" of doing this.

(I got curious and this SPECIAL flag in lib/vsprintf.c has been around
since at least the first 2.6.12-rc2 git commit, so there's nothing new
about it and I suspect it'll never quite be popular...)

-- 
Dominique Martinet | Asmadeus