Re: [PATCH v2] rust: num: bounded: mark __new as unsafe
From: Miguel Ojeda
Date: Wed Dec 03 2025 - 09:23:15 EST
On Wed, Dec 3, 2025 at 1:29 PM Alexandre Courbot <acourbot@xxxxxxxxxx> wrote:
>
> Wasn't it Alice who said that `__new` should be unsafe?
The issue was about making it unsafe -- I added the "Otherwise" branch
to make it a bit more "open", i.e. sometimes I try to make those "good
first issues" in a way that it is not completely automated, e.g. here
so that the new contributor has to think what it means for a function
to be unsafe or not, rather than just converting it. Given Hsiu's
reply in v1, it seems it worked! :)
Cheers,
Miguel