Re: [PATCH v2 4/8] arm64: dts: qcom: Add support for Surface Pro 11

[Konrad Dybcio]

On 12/2/25 7:50 PM, Jérôme de Bretagne wrote:
> Hello,
> 
> As discussed with Dale, I will take over the v3 submission since we've
> worked on this patchset together until now. Here is my feedback below.
> 
> Le lun. 1 déc. 2025 à 16:35, Konrad Dybcio
> <konrad.dybcio@xxxxxxxxxxxxxxxx> a écrit :
>>
>> On 12/1/25 2:14 AM, Dale Whinham wrote:
>>> Add device trees for the Qualcomm X1E and X1P-based Microsoft Surface
>>> Pro 11 machines (codenamed 'Denali').
>>>
>>> This device is very similar to the Surface Laptop 7 ('Romulus').
>>>
>>> Use a similar strategy to x1-asus-zenbook-a14.dtsi so that we can create
>>> x1e and x1p-specific flavors of the device tree without too much code
>>> duplication.
>>
>> [...]
>>
>>> +             pinctrl-0 = <&hall_int_n_default>;
>>> +             pinctrl-names = "default";in v3
>>> +
>>> +             switch-lid {
>>> +                     gpios = <&tlmm 2 GPIO_ACTIVE_LOW>;
>>> +                     linux,input-type = <EV_SW>;
>>> +                     linux,code = <SW_LID>;
>>
>> I.. don't think this device has a lid - what triggers this GPIO?
> 
> When a Surface tablet is connected to a Surface keyboard, opening/closing
> the keyboard triggers a wakeup/suspend event. I will double-check if this
> entry is involved and will remove/keep it in v3 based on this check.

If you have a magnet handy, you can run `evtest` as root and try waving it
around the screen frame - it's presumably just a hall sensor

Konrad