Re: [PATCH v2 1/7] rust: build_assert: add instructions for use with function arguments

From: Miguel Ojeda

Date: Sun Nov 30 2025 - 22:44:29 EST


On Mon, Dec 1, 2025 at 1:52 AM John Hubbard <jhubbard@xxxxxxxxxx> wrote:
>
> More precisely, it was already *hinted* to be inline.

By inline I mean it is marked `#[inline]`, which may or may not get
inlined, but it also has other implications, e.g. codegen can get
delayed even if there are no callers and is concrete.

> Then that is conceptually wrong, because it must be a runtime check.

No, it is not true it must be a runtime check -- it depends: you can
use such a function in some cases just fine.

That is the point of `build_assert!`, after all.

> Sorry for the fussy detailed questioning here. I'm trying to bottom
> out here because CLIPPY=1 is a very solid requirement before posting
> patches.

No worries, but I don't follow what you mean here. `CLIPPY=1` is still
required to be clean etc.

Cheers,
Miguel