Re: [PATCH] rust: acpi: replace manual zero-initialization with `pin_init::zeroed()`
From: Alexandre Courbot
Date: Sun Nov 30 2025 - 22:36:30 EST
On Sat Nov 29, 2025 at 9:27 PM JST, Atharv Dubey wrote:
> Use `pin_init::zeroed()` instead of `core::mem::zeroed()` for initializing
> `acpi_device_id`. This removes an explicit unsafe block and aligns ACPI
> initialization with the pin-init conversion used across the Rust tree.
>
> Link: https://github.com/Rust-for-Linux/linux/issues/1189
> Signed-off-by: Atharv Dubey <atharvd440@xxxxxxxxx>
> ---
> rust/kernel/acpi.rs | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/rust/kernel/acpi.rs b/rust/kernel/acpi.rs
> index 37e1161c1298..9b8efa623130 100644
> --- a/rust/kernel/acpi.rs
> +++ b/rust/kernel/acpi.rs
> @@ -39,9 +39,7 @@ impl DeviceId {
> pub const fn new(id: &'static CStr) -> Self {
> let src = id.to_bytes_with_nul();
> build_assert!(src.len() <= Self::ACPI_ID_LEN, "ID exceeds 16 bytes");
> - // Replace with `bindings::acpi_device_id::default()` once stabilized for `const`.
Let's keep this comment as well.