Re: [PATCH] rust: auxiliary: use `pin_init::zeroed()` for device ID

From: Alexandre Courbot

Date: Sun Nov 30 2025 - 22:35:02 EST


On Sat Nov 29, 2025 at 9:47 PM JST, Atharv Dubey wrote:
> Replace the previous `unsafe { core::mem::zeroed() }` initialization
> for `bindings::auxillary_device_id` with `pin_init::zeroed()`. This removes
> the explicit unsafe block and uses the safer pinned zero-initialization
> helper.
>
> Signed-off-by: Atharv Dubey <atharvd440@xxxxxxxxx>
> ---
> rust/kernel/auxiliary.rs | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/rust/kernel/auxiliary.rs b/rust/kernel/auxiliary.rs
> index 7a3b0b9c418e..67c5d356d754 100644
> --- a/rust/kernel/auxiliary.rs
> +++ b/rust/kernel/auxiliary.rs
> @@ -108,11 +108,7 @@ pub const fn new(modname: &'static CStr, name: &'static CStr) -> Self {
> let name = name.to_bytes_with_nul();
> let modname = modname.to_bytes_with_nul();
>
> - // TODO: Replace with `bindings::auxiliary_device_id::default()` once stabilized for
> - // `const`.

I'd still keep this `TODO`, a `Default` implementation is more adequate
that `Zeroable` here even if they end up doing the same.

Nitpicky: there are two spaces in `for device` in the patch subject.