Re: [PATCH v1 16/31] serial: 8250_mxpcie: optimize Tx using memory-mapped FIFO access

[Andy Shevchenko]

On Sun, Nov 30, 2025 at 12:44 PM Crescent Hsieh
<crescentcy.hsieh@xxxxxxxx> wrote:
>
> Add mxpcie8250_tx_chars() to transmit data via memory-mapped FIFO
> access, using the UART-specific Tx FIFO counter and buffer region.
>
> This replaces serial8250_tx_chars() to reduce per-byte I/O operations
> and improve transmit throughput on Moxa PCIe UART devices.

...

> +static void mxpcie8250_tx_chars(struct uart_8250_port *up)
> +{
> +       struct uart_port *port = &up->port;
> +       struct tty_port *tport = &port->state->port;
> +       unsigned int count, i;
> +       unsigned char c;
> +
> +       if (port->x_char) {
> +               uart_xchar_out(port, UART_TX);
> +               return;
> +       }
> +       if (uart_tx_stopped(port) || kfifo_is_empty(&tport->xmit_fifo)) {
> +               port->ops->stop_tx(port);
> +               return;
> +       }

> +       count = kfifo_len(&tport->xmit_fifo);
> +       count = min(count, port->fifosize - serial_in(up, MOXA_PUART_TX_FIFO_CNT));

Perhaps

  unsigned int i, count, txsize;
  ...
  txsize = serial_in(up, MOXA_PUART_TX_FIFO_CNT);
  count = min(kfifo_len(...), fifosize - txsize);

?

> +       for (i = 0; i < count; ++i) {
> +               if (!uart_fifo_get(port, &c))
> +                       break;

> +               *(port->membase + MOXA_PUART_TX_FIFO_MEM + i) = c;

This is interesting... Why can't the proper IO accessors be used?

> +       }
> +       if (kfifo_len(&tport->xmit_fifo) < WAKEUP_CHARS)
> +               uart_write_wakeup(port);
> +
> +       if (kfifo_is_empty(&tport->xmit_fifo) && !(up->capabilities & UART_CAP_RPM))
> +               port->ops->stop_tx(port);
> +}

-- 
With Best Regards,
Andy Shevchenko