Re: [PATCH 1/2] dt-bindings: pwm: eswin: Add EIC7700 pwm controller

[Krzysztof Kozlowski]

On Fri, Dec 05, 2025 at 05:04:50PM +0800, dongxuyang@xxxxxxxxxxxxxxxxxx wrote:
> diff --git a/Documentation/devicetree/bindings/pwm/eswin,eic7700-pwm.yaml b/Documentation/devicetree/bindings/pwm/eswin,eic7700-pwm.yaml
> new file mode 100644
> index 000000000000..8b7dc7d4dffe
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/eswin,eic7700-pwm.yaml
> @@ -0,0 +1,73 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pwm/eswin,eic7700-pwm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ESWIN EIC7700 PWM controller
> +
> +maintainers:
> +  - Xiang Xu <xuxiang@xxxxxxxxxxxxxxxxxx>
> +  - Guosheng Wang <wangguosheng@xxxxxxxxxxxxxxxxxx>
> +  - Xuyang Dong <dongxuyang@xxxxxxxxxxxxxxxxxx>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  The EIC7700 PWM used the DesignWare APB timers module. The PWM driver
> +  supports a duty cycle range from 0% to 100%, with explicit support for

Driver is irrelevant here. Describe hardware.

> +  both 0% and 100% duty cycles.
> +
> +allOf:
> +  - $ref: pwm.yaml#
> +
> +properties:
> +  compatible:
> +    const: eswin,eic7700-pwm
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  resets:
> +    maxItems: 1
> +
> +  "#pwm-cells":
> +    const: 3
> +
> +  pinctrl-0: true
> +  pinctrl-1: true
> +
> +  pinctrl-names:
> +    minItems: 1
> +    items:
> +      - const: default
> +      - const: sleep
> +
> +  snps,pwm-full-range-enable:

1. Wrong vendor prefix, thats eswin, not snps.
2. Why is this a hardware property? I really do not see that. You
described the desired Linux feature or behavior, not the actual
hardware. The bindings are about the latter, so instead you need to
rephrase the property and its description to match actual hardware
capabilities/features/configuration etc.

Best regards,
Krzysztof