Re: [PATCH v4 1/2] dt-bindings: iio: pressure: add honeywell,abp2030pa

From: Krzysztof Kozlowski

Date: Mon Dec 08 2025 - 02:21:57 EST


On 08/12/2025 08:15, Petre Rodan wrote:
>
> hello Krzysztof,
>
> On Mon, Dec 08, 2025 at 06:01:46AM +0100, Krzysztof Kozlowski wrote:
>> On 07/12/2025 07:00, Petre Rodan wrote:
>>> Adds binding for digital Honeywell ABP2 series pressure and temperature
>>> sensors.
>>> The i2c address is hardcoded and depends on the part number.
>>> There is an optional interrupt that signals the end of conversion.
>>>
>>> Signed-off-by: Petre Rodan <petre.rodan@xxxxxxxxxxxxxxx>
>>
>> <form letter>
>> This is a friendly reminder during the review process.
>>
>> It looks like you received a tag and forgot to add it.
>
> [..]
>
>> If a tag was not added on purpose, please state why and what changed.
>> </form letter>
>
> I removed the tag on purpose since the yaml file was modified in v4 as per the
> changelog that is below the commit message.

Please read my form letter and please read linked submitting patches
doc. I pointed to a very specific paragraph, so you don't need to read
everything...

>
>> I will not be doing work twice and, without explanation, forcing me to
>> do that is disrespectful to my time.
>
> sorry about that. the single thing that changed was that
>
> ---- 8< --------------------------------------------
> @@ -76,8 +71,7 @@ properties:
> spi-max-frequency:
> maximum: 800000
>
> - vdd-supply:
> - description: provide VDD power to the sensor.
> + vdd-supply: true
>


This is trivial and absolutely NOT a reason to drop the tag. Did you
read submitting patches document? Please consider TIME of reviewers,
even time spent on replying on this.

Best regards,
Krzysztof