Re: [PATCH 1/2] arm64: dts: qcom: sm8550: Fix compile warnings in USB controller node

[Neil Armstrong]

On 12/3/25 16:07, Krzysztof Kozlowski wrote:
> On 03/12/2025 15:48, Krishna Kurapati wrote:
> > With W=1, the following error comes up:
> >
> > Warning (avoid_unnecessary_addr_size): /soc@0/usb@a600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
> >
> > This is because the child node being removed during flattening and moving
> > to latest bindings.
> >
> > Fixes: 33450878adfc ("arm64: dts: qcom: sm8550: Flatten the USB nodes")
>
>
> I don't fully understand that original commit - it explicitly changed
> address/size-cells from 2 to 1 and 0, so keeping address/size-cells was
> kind of intentional. Anyway, these should not be needed, so:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

They were kept to allow adding usb submodes representing usb devices,
as the bindings allows. It's not _needed_ until we add some subnodes.

Neil

> Best regards,
> Krzysztof