Re: [PATCH v2 0/4] gpu: nova-core: Fixups for GSP message queue and bindings
From: Alexandre Courbot
Date: Mon Dec 08 2025 - 05:09:38 EST
On Sun Nov 23, 2025 at 2:12 PM JST, Alexandre Courbot wrote:
> This series contains a few fixups for the recently merged GSP
> command-queue code, by order of importance:
>
> - Some explicit padding required to safely implement `AsBytes` was
> missing in the bindings,
> - A bug in the received message length calculation results in the
> message handler being given more data than it should,
> - `MaybeZeroable` is now derived by the kernel's bindgen, but the Nova
> bindings have not been updated for that,
> - Some items in the bindings were referred to using the version module
> directly, instead of the alias we defined to limit the diff when we
> upgrade firmware versions.
>
> All of them address "bugs" (with the first two fixing actual correctness
> issues), but since Nova does not do much anyway, they are also not
> absolutely critical and can wait -rc1 if we prefer to do so.
Alice, Danilo, how would you like to proceed with this series? We could
either:
* Merge this into `drm-rust-next` if you are planning on sending another
before -rc1,
* Wait until -rc1 gets released and send it via `drm-rust-fixes` for
-rc2,
* ... or just take it for 6.20, as it is not absolutely critical.
I am not very familiar with how to do things after the merge window has
opened, so appreciate your guidance here.