Re: [PATCH 1/4] Revert "drm/atomic-helper: Re-order bridge chain pre-enable and post-disable"
From: Aradhya Bhatia
Date: Mon Dec 08 2025 - 06:23:56 EST
Hi Tomi,
Thank you for posting this series.
It makes sense to change the order in tidss _commit_tail(), than to
undo the order changes in the regressed drivers.
On 05/12/2025 09:51, Tomi Valkeinen wrote:
> This reverts commit c9b1150a68d9362a0827609fc0dc1664c0d8bfe1.
>
> Changing the enable/disable sequence has caused regressions on multiple
> platforms: R-Car, MCDE, Rockchip. A series (see link below) was sent to
> fix these, but it was decided that it's better to revert the original
> patch and change the enable/disable sequence only in the tidss driver.
>
> Reverting this commit breaks tidss's DSI and OLDI outputs, which will be
> fixed in the following commits.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>
> Link: https://lore.kernel.org/all/20251202-mcde-drm-regression-thirdfix-v6-0-f1bffd4ec0fa%40kernel.org/
> Fixes: c9b1150a68d9 ("drm/atomic-helper: Re-order bridge chain pre-enable and post-disable")
> Cc: stable@xxxxxxxxxxxxxxx # v6.17+
> ---
> drivers/gpu/drm/drm_atomic_helper.c | 8 +-
> include/drm/drm_bridge.h | 249 ++++++++++--------------------------
> 2 files changed, 70 insertions(+), 187 deletions(-)
>
Reviewed-by: Aradhya Bhatia <aradhya.bhatia@xxxxxxxxx>