Re: [PATCH v2 2/3] of: factor arguments passed to of_map_id() into a struct

[Vijayanand Jitta]

On 12/5/2025 10:17 PM, Dmitry Baryshkov wrote:
> On 04/12/2025 11:55, Vijayanand Jitta wrote:
>> From: Charan Teja Kalla <charan.kalla@xxxxxxxxxxxxxxxx>
>>
>> Introduce a new struct type where the optional arguments passed to
>> of_map_id() are in struct. Subsequent patches add additional arguments
>> to the struct that the caller expects to be filled of_map_id().
> 
> Why do we need a separate struct? Can't we use of_phandle_args instead?
> 

The idea is to use it for multi-map support mentioned in the cover letter,
where we need to pass additional context (callback, dev etc..). Having a
seperate structure here makes of_map_id() interface easier to extend.

>>
>> Signed-off-by: Charan Teja Kalla <charan.kalla@xxxxxxxxxxxxxxxx>
>> Signed-off-by: Vijayanand Jitta <vijayanand.jitta@xxxxxxxxxxxxxxxx>
>> ---
>>   drivers/iommu/of_iommu.c              |  6 +++++-
>>   drivers/of/base.c                     | 31 ++++++++++++++-------------
>>   drivers/pci/controller/dwc/pci-imx6.c |  6 +++++-
>>   drivers/pci/controller/pcie-apple.c   |  5 ++++-
>>   drivers/xen/grant-dma-ops.c           |  5 ++++-
>>   include/linux/of.h                    | 23 ++++++++++++++------
>>   6 files changed, 50 insertions(+), 26 deletions(-)
>>