Re: [PATCH] ACPI: processor: idle: Add debug log for the state whose entry method is illegal

[Jonathan Cameron]

On Tue, 25 Nov 2025 14:47:02 +0800
Huisong Li <lihuisong@xxxxxxxxxx> wrote:

> According to ACPI spec, entry method in LPI sub-package must be buffer
> or integer. Driver will disable the state whose the entry method is
> illegal by zero flags in struct acpi_lpi_state. The entry method is
> very key in cpuidle. A debug log is very useful developers.
> 
> Signed-off-by: Huisong Li <lihuisong@xxxxxxxxxx>
Seems reasonable to me and debug is probably appropriate error for broken
firmware. 
Reviewed-by: Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>

> ---
>  drivers/acpi/processor_idle.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index 22909fccf0b1..5f86297c8b23 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -946,6 +946,8 @@ static int acpi_processor_evaluate_lpi(acpi_handle handle,
>  			lpi_state->entry_method = ACPI_CSTATE_INTEGER;
>  			lpi_state->address = obj->integer.value;
>  		} else {
> +			pr_debug("Entry method of state-%d is illegal, disable it.\n",
> +				 state_idx);
>  			continue;
>  		}
>