Re: [PATCH v2] lib/crypto: riscv/chacha: Avoid s0/fp register

From: Eric Biggers
Date: Mon Dec 08 2025 - 18:09:20 EST


On Tue, Dec 02, 2025 at 01:25:07PM +0800, Vivian Wang wrote:
> In chacha_zvkb, avoid using the s0 register, which is the frame pointer,
> by reallocating KEY0 to t5. This makes stack traces available if e.g. a
> crash happens in chacha_zvkb.
>
> No frame pointer maintenence is otherwise required since this is a leaf
> function.
>
> Signed-off-by: Vivian Wang <wangruikang@xxxxxxxxxxx>
> ---
> Changes in v2:
> - Remove frame pointer maintenance, and simply avoid touching s0. Since
> this is a leaf function, this also allows unwinding to work.
> - Link to v1: https://lore.kernel.org/r/20251130-riscv-chacha_zvkb-fp-v1-1-68ef7a6d477a@xxxxxxxxxxx
> ---
>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-fixes

- Eric