Re: [PATCH v3] arm64: defconfig: Enable QCOMTEE on Qualcomm SM8650+
From: Dmitry Baryshkov
Date: Tue Dec 09 2025 - 01:15:01 EST
On Tue, 9 Dec 2025 at 07:58, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On 08/12/2025 13:18, Harshal Dev wrote:
> > Enable QCOMTEE driver on Qualcomm SM8650+ SoCs to facilitate communication
> > with the Qualcomm Trusted Execution Environment (QTEE).
> > (No enablement required in DTS files since QCOMTEE device is dynamically
> > registered by the QCOM_SCM firmware driver)
> >
> > Signed-off-by: Harshal Dev <harshal.dev@xxxxxxxxxxxxxxxx>
> > ---
> > Changes in v3:
> > - Updated the commit message to reflect the supported Qualcomm platforms.
> > - Link to v2: https://lore.kernel.org/r/20251205-qcom_qcomtee_defconfig-v2-1-c92560b0346e@xxxxxxxxxxxxxxxx
> >
>
> I gave you the exact example to follow. Maybe it is not that important
> for others, so I will not object, but OTOH it is important for me, thus
> I will not give reviewed by. I damn asked VERY CLEARLY:
>
> "Just mention which UPSTREAM boards (which you called Qualcomm
> platforms) use this driver."
+1 Here. Defconfig changes mention devices, not SoC families.
>
> Usage of something on SoC is not a proof that it actually is used by
> upstream platforms and we absolutely do not care at all about downstream
> users. I spent way too much time on this and even very specific
> instructions were not working, so I don't know how else I can help.
>
> Best regards,
> Krzysztof
--
With best wishes
Dmitry