Re: [PATCH] resource: add WARN_ON_ONCE for resource_size() and document misusage
From: Andy Shevchenko
Date: Tue Dec 09 2025 - 10:07:26 EST
On Tue, Dec 09, 2025 at 12:25:38PM +0200, Ilpo Järvinen wrote:
> On Mon, 8 Dec 2025, Christian Marangi wrote:
...
> > static inline resource_size_t resource_size(const struct resource *res)
> > {
> > + WARN_ON_ONCE(!res->flags);
>
> As lkp also found out, you need to add #include <linux/bug.h>
Since it's header, we may use better one from asm, i.e. asm/bug.h.
This will give finer granularity and less possible tangled dependencies
in the future.
> > return res->end - res->start + 1;
> > }
--
With Best Regards,
Andy Shevchenko